Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CompatHelper: bump compat for CairoMakie to 0.11 for package test, (keep existing compat) #1841

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

CompatHelper: bump compat for CairoMakie to 0.11 for package test, (keep existing compat) #1841

wants to merge 3 commits into from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 8, 2024

This pull request changes the compat entry for the CairoMakie package from 0.6, 0.7, 0.8, 0.9, 0.10 to 0.6, 0.7, 0.8, 0.9, 0.10, 0.11 for package test.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@github-actions github-actions bot force-pushed the compathelper/new_version/2024-02-08-00-04-47-499-04167947785 branch from 17e7ab1 to 9eb80a6 Compare February 8, 2024 00:04
@ranocha ranocha closed this Feb 13, 2024
@ranocha ranocha reopened this Feb 13, 2024
@ranocha ranocha enabled auto-merge (squash) February 13, 2024 18:36
@codecov Codecov
Copy link

codecov bot commented Feb 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c5e743a) 89.67% compared to head (62cb68f) 84.31%.
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1841      +/-   ##
==========================================
- Coverage   89.67%   84.31%   -5.36%     
==========================================
  Files         458      458              
  Lines       36400    36396       -4     
==========================================
- Hits        32640    30686    -1954     
- Misses       3760     5710    +1950
Flag Coverage Δ
unittests 84.31% <ø> (-5.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ranocha ranocha disabled auto-merge February 14, 2024 06:38
@ranocha
Copy link
Member

ranocha commented Feb 14, 2024

Aha, there are some breaking changes that affect us:

Makie visualization tests for UnstructuredMesh2D: Error During Test at /home/runner/work/Trixi.jl/Trixi.jl/test/test_trixi.jl:184
  Got exception outside of a @test
  type Camera3D has no field attributes
  Stacktrace:
    [1] getproperty(x::Makie.Camera3D, f::Symbol)
      @ Base ./Base.jl:37
    [2] iplot(pd::Trixi.PlotData2DTriangulated{StructArrays.StructArray{StaticArraysCore.SVector{4, Float64}, 2, NTuple{4, Matrix{Float64}}, Int64}, Matrix{Float64}, Matrix{Float64}, StructArrays.StructArray{StaticArraysCore.SVector{4, Float64}, 2, NTuple{4, Matrix{Float64}}, Int64}, StaticArraysCore.SVector{4, String}, Matrix{Int32}}; plot_mesh::Bool, show_axis::Bool, colormap::Symbol, variable_to_plot_in::Int64)
      @ TrixiMakieExt ~/work/Trixi.jl/Trixi.jl/ext/TrixiMakieExt.jl:265
...

See https://github.com/trixi-framework/Trixi.jl/actions/runs/7891195904/job/21534998549?pr=1841#step:7:3749

ranocha
ranocha requested changes Feb 14, 2024
View reviewed changes
Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to adapt this to the breaking changes and update the compat settings afterwards.

@sloede
Copy link
Member

sloede commented Feb 14, 2024

@jlchan this looks like it could be code from you. Would you be able to take a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranocha ranocha ranocha requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
upstream visualization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ranocha @sloede @jlchan